Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CRA with Vite #74

Merged
merged 87 commits into from
Oct 16, 2024
Merged

Replace CRA with Vite #74

merged 87 commits into from
Oct 16, 2024

Conversation

AjobK
Copy link
Member

@AjobK AjobK commented Sep 19, 2024

Closes #72

Problem

The compilation process for CRA is long and official support is also being cut off.

Solution

Moving to Vite, which is significantly faster!

src/hooks/useError.test.ts Outdated Show resolved Hide resolved
src/pages/Auth/utils.ts Outdated Show resolved Hide resolved
src/serviceWorkerRegistration.ts Outdated Show resolved Hide resolved
vite.config.ts Outdated Show resolved Hide resolved
@AjobK AjobK requested a review from tomasr8 September 19, 2024 14:24
@AjobK
Copy link
Member Author

AjobK commented Sep 20, 2024

Update:

Everything works, but the manifest.json is not properly cached to work offline. The rest is cached properly.

I believe I have found a way to cache the manifest.json, but for some reason the frontend is giving errors. Looking into it

Copy link

📝 Lighthouse report

@GovernmentPlates
Copy link
Member

Remember to update the dev instructions in the README! :)

@AjobK
Copy link
Member Author

AjobK commented Oct 7, 2024

@GovernmentPlates The README is still up-to-date. If you refer to the commands that we use, they are the same as we use the abstraction provided by our package.json. The command behind for example npm start is changed, but we still use npm start.

Update
Discussed and confirmed with @GovernmentPlates

@tomasr8 tomasr8 merged commit 3c8ed92 into indico:master Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace CRA SW with VitePWA SW
3 participants